sql/schemachanger: implement CREATE OR REPLACE FUNCTION with Drop/Add #163286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for bool fields in the rel package's schema system, alongside new UInt32Value, BoolValue, and Int32Value attributes in screl. These attributes enable function element properties (Volatility, LeakProof, NullInputBehavior, Security, Body) to be mapped with distinguishing keys, which is a prerequisite for using the drop+add pattern for CREATE OR REPLACE FUNCTION. The rel package changes include: - Bool field support in schema, comparison, and value conversion - Relaxed checkType to compare scalar kinds by their comparable base type rather than named type, allowing different named types of the same kind (e.g. Function_Volatility and Function_NullInputBehavior) to share a single attribute The screl changes add entity attr mappings for: - FunctionVolatility (Int32Value) - FunctionLeakProof (BoolValue) - FunctionNullInputBehavior (Int32Value) - FunctionBody (Value) - FunctionSecurity (Int32Value) Release note: none Epic: None Co-Authored-By: Claude Opus 4.6 <[email protected]>
Previously, CREATE OR REPLACE FUNCTION was not supported in the declarative schema changer and fell back to the legacy schema changer via NotImplementedError. This commit implements CREATE OR REPLACE using the drop+add pattern already established by TableStorageParam, RowLevelTTL, and zone configs. Each mutable sub-element (FunctionBody, FunctionVolatility, FunctionLeakProof, FunctionNullInputBehavior, FunctionSecurity, FunctionParams) is dropped and re-added with the new values, while Function, SchemaChild, FunctionName, Owner, and UserPrivileges remain untouched. Key changes: - Add replaceFunction in create_function.go with validation: routine kind match, return type match (including UDT equivalence), parameter name/type constraints, trigger function checks. Options not specified are reset to defaults, matching legacy resetFuncOption behavior. - Introduce FunctionParams as a standalone element owning the SetFunctionParams mutation, rather than only having params in scpb.Function. - Add SeqNum to FunctionBody and FunctionParams for element key uniqueness when content is unchanged during replace. - Add SameStagePrecedence dep rules ensuring old elements are dropped before new ones are added. - Enhance UpdateFunctionRelationReferences execution to clean up stale back-references from relations and functions no longer depended on. Epic: CRDB-42942 Release note: None
This helps reduce noise in error output. If an error with a PG code occurs during this stage, it means that it's because of a user action, so we shoul avoid showing additional debug info. Release note: None
Contributor
|
Merging to
|
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Collaborator
Author
|
closing since this was just a proof of concept; we're merging #163210 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a draft PR to prototype a suggestion from the review of #163210
Previously, CREATE OR REPLACE FUNCTION was not supported in the
declarative schema changer and fell back to the legacy schema changer
via NotImplementedError.
This commit implements CREATE OR REPLACE using the drop+add pattern
already established by TableStorageParam, RowLevelTTL, and zone configs.
Each mutable sub-element (FunctionBody, FunctionVolatility,
FunctionLeakProof, FunctionNullInputBehavior, FunctionSecurity,
FunctionParams) is dropped and re-added with the new values, while
Function, SchemaChild, FunctionName, Owner, and UserPrivileges remain
untouched.
Key changes:
kind match, return type match (including UDT equivalence), parameter
name/type constraints, trigger function checks. Options not specified
are reset to defaults, matching legacy resetFuncOption behavior.
SetFunctionParams mutation, rather than only having params in
scpb.Function.
uniqueness when content is unchanged during replace.
before new ones are added.
back-references from relations and functions no longer depended on.
Epic: CRDB-42942
Release note: None